[webkit-reviews] review granted: [Bug 208775] Replan the use of term "rollout" to "revert" in various tools : [Attachment 392910] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 208775: Replan the use of term "rollout" to "revert" in various tools
https://bugs.webkit.org/show_bug.cgi?id=208775

Attachment 392910: Patch

https://bugs.webkit.org/attachment.cgi?id=392910&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 392910
  --> https://bugs.webkit.org/attachment.cgi?id=392910
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392910&action=review

> Tools/ChangeLog:3
> +	   [Tools] Out with rollouts, in with reverts

This bug title was too confusing.

> Tools/Scripts/webkitpy/common/net/bugzilla/attachment.py:84
> +    def is_revert(self):
> +	   return self.name().startswith(self.revert_preamble)

We need to check both rollout & revert here
because this function is used to check whether something is a rollout or a
revert.

> Tools/Scripts/webkitpy/tool/bot/irc_command.py:156
> +    usage_string = "revert SVN_REVISION [SVN_REVISIONS] REASON"
> +    help_string = "Opens a revert bug, CCing author + reviewer, and
attaching the reverse-diff of the given revisions marked as commit-queue=?."

While we're at, we should rephrase this as "Opens a bug to revert the specified
revision, ..."

> Tools/Scripts/webkitpy/tool/bot/irc_command.py:245
> -	       tool.irc().post("%s: Created rollout: %s" % (nicks_string,
bug_url))
> +	       tool.irc().post("%s: Created revert: %s" % (nicks_string,
bug_url))

While we're at it, we should rephrase it to "Created a revert patch":

> Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:157
> -		   return '%s rolled out %s in %s : %s' % (author,
rollout.group('revisions'),
> +		   return '%s rolled out %s in %s : %s' % (author,
revert.group('revisions'),

We should rephrase this as "reverted" as well.

> Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:159
> -	       lines[0] = '%s rolled out %s in %s' % (author,
rollout.group('revisions'), linkified_revision)
> +	       lines[0] = '%s rolled out %s in %s' % (author,
revert.group('revisions'), linkified_revision)

Ditto.