[webkit-reviews] review granted: [Bug 208720] [iOS] Implement support for dictation alternatives : [Attachment 392876] Part 2: Move insertDictatedTextAsync() from the Mac-specific files to Cocoa-specific files

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 208720: [iOS] Implement support for dictation alternatives
https://bugs.webkit.org/show_bug.cgi?id=208720

Attachment 392876: Part 2: Move insertDictatedTextAsync() from the Mac-specific
files to Cocoa-specific files

https://bugs.webkit.org/attachment.cgi?id=392876&action=review




--- Comment #22 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 392876
  --> https://bugs.webkit.org/attachment.cgi?id=392876
Part 2: Move insertDictatedTextAsync() from the Mac-specific files to
Cocoa-specific files

View in context: https://bugs.webkit.org/attachment.cgi?id=392876&action=review

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:259
> +    options.registerUndoGroup = registerUndoGroup;

(Not related to this patch)

At some point, we should consider changing InsertTextOptions’s bool members
into enum classes.