[webkit-reviews] review granted: [Bug 208720] [iOS] Implement support for dictation alternatives : [Attachment 392872] Part 1: Share AlternativeTextUIController

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 208720: [iOS] Implement support for dictation alternatives
https://bugs.webkit.org/show_bug.cgi?id=208720

Attachment 392872: Part 1: Share AlternativeTextUIController

https://bugs.webkit.org/attachment.cgi?id=392872&action=review




--- Comment #15 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 392872
  --> https://bugs.webkit.org/attachment.cgi?id=392872
Part 1: Share AlternativeTextUIController

View in context: https://bugs.webkit.org/attachment.cgi?id=392872&action=review

> Source/WebCore/ChangeLog:14
> +	   Note that I haven't enable USE_DICTATION_ALTERNATIVES on iOS, yet.
So, this code isn't being compile on it.

Nit - "being compiled"

> Source/WebKit/UIProcess/ios/PageClientImplIOS.h:37
> +OBJC_CLASS NSTextAlternatives;

Nit - alphabetic order.