[webkit-reviews] review granted: [Bug 208464] Lazily generate CGPaths for some simple types of paths, such as arcs and lines : [Attachment 392801] v2

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 208464: Lazily generate CGPaths for some simple types of paths, such as
arcs and lines
https://bugs.webkit.org/show_bug.cgi?id=208464

Attachment 392801: v2

https://bugs.webkit.org/attachment.cgi?id=392801&action=review




--- Comment #13 from Tim Horton <thorton at apple.com> ---
Comment on attachment 392801
  --> https://bugs.webkit.org/attachment.cgi?id=392801
v2

View in context: https://bugs.webkit.org/attachment.cgi?id=392801&action=review

> Source/WebCore/platform/graphics/Path.h:233
> +    struct LineData {

Feels weird that this is in USE(CG). Should it be in a
ENABLE(PLATFORM_INDEPENDENT_PATHS) (probably not that name) that is only on in
CG for now? I assume the reason that you didn't is that it still needs the
platform path to fall back on if it's not one of the simple types? But even
that could be true for the other graphics frameworks.