[webkit-reviews] review denied: [Bug 208752] [Media in GPU Process] Implement caption support in video fullscreen and PiP : [Attachment 392849] WIP patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 208752: [Media in GPU Process] Implement caption support in video
fullscreen and PiP
https://bugs.webkit.org/show_bug.cgi?id=208752

Attachment 392849: WIP patch

https://bugs.webkit.org/attachment.cgi?id=392849&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 392849
  --> https://bugs.webkit.org/attachment.cgi?id=392849
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392849&action=review

> Source/WebCore/dom/Document.cpp:2103
> +	   // ASSERT_NOT_REACHED();

You cannot remove this. If this hits, you're doing something wrong.

> Source/WebCore/rendering/RenderLayer.cpp:5703
> +	       // ASSERT(clipRectsContext.rootLayer ==
m_clipRectsCache->m_clipRectsRoot[clipRectsType]);
> +	       // ASSERT(m_clipRectsCache->m_scrollbarRelevancy[clipRectsType]
== clipRectsContext.overlayScrollbarSizeRelevancy);

If you're hitting these you're also doing something wrong.