[webkit-reviews] review granted: [Bug 208736] Add "AndOrdered" to the names of ordered DoubleConditions. : [Attachment 392832] proposed patch.

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 208736: Add "AndOrdered" to the names of ordered DoubleConditions.
https://bugs.webkit.org/show_bug.cgi?id=208736

Attachment 392832: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=392832&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 392832
  --> https://bugs.webkit.org/attachment.cgi?id=392832
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=392832&action=review

r=me.

>> Source/JavaScriptCore/ChangeLog:19
>> +	    Adding "AndOrdered" to their names makes this property explicit.
> 
> Isn't this sort of implied?

Can you note that this is interesting because on most CPUs DoubleNotEqual is
DoubleNotEqualOrUnordered?