[webkit-reviews] review granted: [Bug 208562] Web Inspector: AXI: no way to expand/collapse sidebar sections with Tab navigation : [Attachment 392828] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 208562: Web Inspector: AXI: no way to expand/collapse sidebar sections with
Tab navigation
https://bugs.webkit.org/show_bug.cgi?id=208562

Attachment 392828: Patch

https://bugs.webkit.org/attachment.cgi?id=392828&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 392828
  --> https://bugs.webkit.org/attachment.cgi?id=392828
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392828&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:107
> +    margin-top: calc(-1 * var(--details-section-header-vertical-padding));

Some explanation as to why this is necessary would be nice :)

> Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:122
> +    outline-offset: -5px;
> +    border-radius: 9px;

These are oddly specific numbers.  How do you come up with them?

> Source/WebInspectorUI/UserInterface/Views/DetailsSection.js:163
> +	   if (event.code === "Space" || event.code === "Enter") {

What's the difference between this (which only appears to be used once or twice
in Web Inspector) and `keyIdentifier === "Left"` (which is used a good amount)?