[webkit-reviews] review granted: [Bug 207436] Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h : [Attachment 392815] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 207436: Move JavaScriptCore related feature defines from
FeatureDefines.xcconfig to PlatformEnableCocoa.h
https://bugs.webkit.org/show_bug.cgi?id=207436

Attachment 392815: Patch

https://bugs.webkit.org/attachment.cgi?id=392815&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 392815
  --> https://bugs.webkit.org/attachment.cgi?id=392815
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392815&action=review

So glad you are doing this. Really not happy with FeatureDefines.xcconfig and
wondering if we need it at all.

> Source/WTF/wtf/PlatformEnableCocoa.h:255
> +#if !defined(ENABLE_FAST_JIT_PERMISSIONS) && CPU(ARM64) && !(OS(TVOS) ||
OS(WATCHOS)) && USE(APPLE_INTERNAL_SDK)

Looks good.

I wonder about PLATFORM(APPLETV) vs. OS(TVOS); I think I’d almost always prefer
OS(TVOS), but PLATFORM(APPLETV) seems much more common.

I wonder about PLATFORM(WATCHOS) vs. OS(WATCHOS).