[webkit-reviews] review granted: [Bug 208661] Add support for inserting and removing a text placeholder : [Attachment 392833] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 208661: Add support for inserting and removing a text placeholder
https://bugs.webkit.org/show_bug.cgi?id=208661

Attachment 392833: Patch

https://bugs.webkit.org/attachment.cgi?id=392833&action=review




--- Comment #49 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 392833
  --> https://bugs.webkit.org/attachment.cgi?id=392833
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392833&action=review

> Source/WebCore/editing/Editor.cpp:3352
> +	   VisibleSelection newSelection { savedPositionBeforePlaceholder,
savedPositionBeforePlaceholder };

You can just pass one of them to VisibleSelection's constructor.

> Source/WebCore/html/shadow/TextPlaceholderElement.cpp:37
> +using namespace HTMLNames;

Can't we just use HTMLNames::divTag below?