[webkit-reviews] review requested: [Bug 208528] UIProcess needs mechanism to specify AppBound domains : [Attachment 392817] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 6 17:39:33 PST 2020


katherine_cheney at apple.com has asked  for review:
Bug 208528: UIProcess needs mechanism to specify AppBound domains
https://bugs.webkit.org/show_bug.cgi?id=208528

Attachment 392817: Patch

https://bugs.webkit.org/attachment.cgi?id=392817&action=review




--- Comment #33 from katherine_cheney at apple.com ---
Comment on attachment 392817
  --> https://bugs.webkit.org/attachment.cgi?id=392817
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392817&action=review

>> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:464
>> +		    if (!url.isValid())
> 
> Did you decide to leave this as a URL to make the code more robust against
improper content in the Info.plist?

Yes, as per recommended after talking with John


More information about the webkit-reviews mailing list