[webkit-reviews] review granted: [Bug 208690] [Cocoa] Re-enable CFPrefs direct mode : [Attachment 392813] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 6 17:25:15 PST 2020


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 208690: [Cocoa] Re-enable CFPrefs direct mode
https://bugs.webkit.org/show_bug.cgi?id=208690

Attachment 392813: Patch

https://bugs.webkit.org/attachment.cgi?id=392813&action=review




--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 392813
  --> https://bugs.webkit.org/attachment.cgi?id=392813
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392813&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:342
> +- (void)_grantAccessToPreferenceService WK_API_AVAILABLE(ios(WK_IOS_TBA));

I think this should be macOS(WK_MAC_TBA), too, shouldn't it?


More information about the webkit-reviews mailing list