[webkit-reviews] review granted: [Bug 208693] [webkitpy] Fix executive on Windows to run wpt server correctly : [Attachment 392812] PATCH

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 208693: [webkitpy] Fix executive on Windows to run wpt server correctly
https://bugs.webkit.org/show_bug.cgi?id=208693

Attachment 392812: PATCH

https://bugs.webkit.org/attachment.cgi?id=392812&action=review




--- Comment #7 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 392812
  --> https://bugs.webkit.org/attachment.cgi?id=392812
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=392812&action=review

> Tools/Scripts/webkitpy/common/system/executive.py:326
> +	       return os.path.join("C:", os.sep, "WINDOWS", "system32",
"taskkill.exe")

Do we actually need os.sep here? I would expect os.path.join(...) to do that
for you.