[webkit-reviews] review denied: [Bug 208711] REGRESSION(r257975): [GTK][WPE] Build failure after a clean build : [Attachment 392791] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 6 16:43:25 PST 2020


Konstantin Tokarev <annulen at yandex.ru> has denied Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 208711: REGRESSION(r257975): [GTK][WPE] Build failure after a clean build
https://bugs.webkit.org/show_bug.cgi?id=208711

Attachment 392791: Patch

https://bugs.webkit.org/attachment.cgi?id=392791&action=review




--- Comment #16 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 392791
  --> https://bugs.webkit.org/attachment.cgi?id=392791
Patch

Still doesn't work here. I guess .idl file should be main product and not
Settings.h, as it's needed earlier (or idl generation should depend on
Setting.h, but that would be illogical)


More information about the webkit-reviews mailing list