[webkit-reviews] review granted: [Bug 208698] Some PDFPlugin cleanup in prep for incremental loading : [Attachment 392719] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 208698: Some PDFPlugin cleanup in prep for incremental loading
https://bugs.webkit.org/show_bug.cgi?id=208698

Attachment 392719: Patch

https://bugs.webkit.org/attachment.cgi?id=392719&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 392719
  --> https://bugs.webkit.org/attachment.cgi?id=392719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392719&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:275
> +    WebFrame& m_frame;

Should we use a WeakPtr instead?

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1347
> +    if (FrameView* frameView = m_frame.coreFrame()->view())

auto?

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1854
> +    Frame* frame = m_frame.coreFrame();

auto?