[webkit-reviews] review requested: [Bug 208731] Fix some issues in the ARM64 moveConditionallyAfterFloatingPointCompare() and moveDoubleConditionallyAfterFloatingPointCompare(). : [Attachment 392762] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 6 14:19:17 PST 2020


Saam Barati <sbarati at apple.com> has asked  for review:
Bug 208731: Fix some issues in the ARM64
moveConditionallyAfterFloatingPointCompare() and
moveDoubleConditionallyAfterFloatingPointCompare().
https://bugs.webkit.org/show_bug.cgi?id=208731

Attachment 392762: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=392762&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 392762
  --> https://bugs.webkit.org/attachment.cgi?id=392762
proposed patch.

there is more to be done here. We're calling it "cmov", but we're now
implementing it as select. Is that ok?


More information about the webkit-reviews mailing list