[webkit-reviews] review granted: [Bug 208731] Fix some issues in the ARM64 moveConditionallyAfterFloatingPointCompare() and moveDoubleConditionallyAfterFloatingPointCompare(). : [Attachment 392762] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 208731: Fix some issues in the ARM64
moveConditionallyAfterFloatingPointCompare() and
moveDoubleConditionallyAfterFloatingPointCompare().
https://bugs.webkit.org/show_bug.cgi?id=208731

Attachment 392762: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=392762&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 392762
  --> https://bugs.webkit.org/attachment.cgi?id=392762
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=392762&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:2030
>	   if (cond == DoubleNotEqual) {

can you file a bug that DoubleNotEqual really means
DoubleNotEqualAndNotUnordered?