[webkit-reviews] review granted: [Bug 208528] UIProcess needs mechanism to specify AppBound domains : [Attachment 392753] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 208528: UIProcess needs mechanism to specify AppBound domains
https://bugs.webkit.org/show_bug.cgi?id=208528

Attachment 392753: Patch

https://bugs.webkit.org/attachment.cgi?id=392753&action=review




--- Comment #12 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 392753
  --> https://bugs.webkit.org/attachment.cgi?id=392753
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392753&action=review

I think this looks good, but I would suggest running it by Chris to make sure
we captured all of this comments.

> Source/WebKit/UIProcess/WebPageProxy.h:2265
> +    void setIsNavigatingToAppBoundDomain(bool isMainFrame, const URL&,
NavigatingToAppBoundDomain);

Much simpler :-)

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:448
> +	   NSArray *domains = [[NSBundle mainBundle]
objectForInfoDictionaryKey:@"AppBoundDomains"];

I think we should use the key "WKAppBoundDomains" to be consistent with other
keys in the system (e.g., SBMatchingApplicationGenres or
MPSupportsExternallyPlayableContent, etc.)

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:461
> +	       initializedAppBoundDomains = true;

Wouldn't it be better to do all of this work in the dispatch queue, and only
dispatch the final result to the main thread? Or did Chris feel that copying
the NSArray across and working in the main thread would be safer?