[webkit-reviews] review granted: [Bug 208719] Web Inspector: Replace Thread icon for WI.ThreadTreeElement : [Attachment 392733] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Jon Davis <jond at apple.com>'s
request for review:
Bug 208719: Web Inspector: Replace Thread icon for WI.ThreadTreeElement
https://bugs.webkit.org/show_bug.cgi?id=208719

Attachment 392733: Patch

https://bugs.webkit.org/attachment.cgi?id=392733&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 392733
  --> https://bugs.webkit.org/attachment.cgi?id=392733
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392733&action=review

r=me

> Source/WebInspectorUI/UserInterface/Images/InstrumentIcons.svg:171
> +    <g id="ThreadInstrument-light" class="light blue"><use
href="#circle"/><use href="#threads"/></g>
> +    <g id="ThreadInstrument-dark" class="dark blue"><use
href="#circle"/><use href="#threads"/></g>

I wouldn't really consider this an "instrument".  That's a concept specific to
timelines.  It's not the worst thing for it to use this as well, but it would
be nice to have it as it's own icon as it's really a unique concept.