[webkit-reviews] review granted: [Bug 208699] [GPUP] Convert CDMFactory away from platformStrategies() and use WebProcess settings instead : [Attachment 392682] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 6 05:35:48 PST 2020


youenn fablet <youennf at gmail.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 208699: [GPUP] Convert CDMFactory away from platformStrategies() and use
WebProcess settings instead
https://bugs.webkit.org/show_bug.cgi?id=208699

Attachment 392682: Patch

https://bugs.webkit.org/attachment.cgi?id=392682&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 392682
  --> https://bugs.webkit.org/attachment.cgi?id=392682
Patch

r=me as long as bots are green.

View in context: https://bugs.webkit.org/attachment.cgi?id=392682&action=review

> Source/WebKit/WebProcess/WebProcess.cpp:2011
> +    cdmFactories.clear();

This seems a bit odd to get the vector, clear it and then refill it and passing
it as a mutable parameter.
I guess this might help for extensibility.

Could we just have something like :
static inline Vector<CDMFactory*> computeFactories()
{
   if (useGPUProcessForMedia)
     return ensureGPUProcessConnection().cdmFactory().computeFactories();
  return CDMFactory::computePlatformFactories();
}
...

    CDMFactory::registerFactories(computeFactories())

> Source/WebKit/WebProcess/WebProcess.cpp:2013
> +    if (useGPUProcessForMedia)

Probably missing a ENABLE(GPU_PROCESS)


More information about the webkit-reviews mailing list