[webkit-reviews] review canceled: [Bug 208566] REGRESSION(r255957): Element with scroll-behavior:smooth isn't draggable after r255957 : [Attachment 392686] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has canceled cathiechen
<cathiechen at igalia.com>'s request for review:
Bug 208566: REGRESSION(r255957): Element with scroll-behavior:smooth isn't
draggable after r255957
https://bugs.webkit.org/show_bug.cgi?id=208566

Attachment 392686: Patch

https://bugs.webkit.org/attachment.cgi?id=392686&action=review




--- Comment #6 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 392686
  --> https://bugs.webkit.org/attachment.cgi?id=392686
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392686&action=review

LGTM, I wonder if we already have tests for this feature and whether we can
adapt them for scroll behavior?

> Source/WebCore/rendering/RenderLayer.cpp:2797
> +void RenderLayer::scrollRectToVisible(const LayoutRect& absoluteRect, bool
insideFixed, const ScrollRectToVisibleOptions& options, bool
isAutoscrollInProgress)

I guess it should be AutoScrollInProgress?