[webkit-reviews] review granted: [Bug 208655] Remove the experimental flag for Pointer Events : [Attachment 392689] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 208655: Remove the experimental flag for Pointer Events
https://bugs.webkit.org/show_bug.cgi?id=208655

Attachment 392689: Patch

https://bugs.webkit.org/attachment.cgi?id=392689&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 392689
  --> https://bugs.webkit.org/attachment.cgi?id=392689
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392689&action=review

Wouldn't you also have to edit every test that has
experimental:PointerEventsEnabled flags?

I think you should remove the compile guard at the same time.

And obviously the bots are not happy :)

> Source/WebCore/dom/Element.idl:105
> +    [Conditional=POINTER_EVENTS, MayThrowException] void
setPointerCapture(long pointerId);
> +    [Conditional=POINTER_EVENTS, MayThrowException] void
releasePointerCapture(long pointerId);
> +    [Conditional=POINTER_EVENTS] boolean hasPointerCapture(long pointerId);

Why wouldn't you remove the compile time flag at the same time?

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:3248
>  - (void)setSyntheticEditingCommandsEnabled:(BOOL)flag
>  {
> -    [self _setBoolValue:flag
forKey:WebKitPointerEventsEnabledPreferenceKey];
> +    [self _setBoolValue:flag
forKey:WebKitSyntheticEditingCommandsEnabledPreferenceKey];
>  }

Whhhhaaaat?