[webkit-reviews] review granted: [Bug 208670] Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations : [Attachment 392648] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 208670: Add WKNavigationDelegatePrivate SPI to inform application of
subframe navigations
https://bugs.webkit.org/show_bug.cgi?id=208670

Attachment 392648: Patch

https://bugs.webkit.org/attachment.cgi?id=392648&action=review




--- Comment #5 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 392648
  --> https://bugs.webkit.org/attachment.cgi?id=392648
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392648&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:112
> +- (void)_webView:(WKWebView *)webView
didStartProvisionalLoadWithRequest:(NSURLRequest *)request inFrame:(WKFrameInfo
*)frame WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
> +- (void)_webView:(WKWebView *)webView
didFailProvisionalLoadWithRequest:(NSURLRequest *)request inFrame:(WKFrameInfo
*)frame withError:(NSError *)error WK_API_AVAILABLE(macos(WK_MAC_TBA),
ios(WK_IOS_TBA));
> +- (void)_webView:(WKWebView *)webView didCommitLoadWithRequest:(NSURLRequest
*)request inFrame:(WKFrameInfo *)frame WK_API_AVAILABLE(macos(WK_MAC_TBA),
ios(WK_IOS_TBA));
> +- (void)_webView:(WKWebView *)webView didFailLoadWithRequest:(NSURLRequest
*)request inFrame:(WKFrameInfo *)frame withError:(NSError *)error
WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
> +- (void)_webView:(WKWebView *)webView didFinishLoadWithRequest:(NSURLRequest
*)request inFrame:(WKFrameInfo *)frame WK_API_AVAILABLE(macos(WK_MAC_TBA),
ios(WK_IOS_TBA));

If this is subframe only, I'd like that to be clear.

"inSubframe:" or "inNonMainFrame:" etc.