[webkit-reviews] review denied: [Bug 208641] webkitpy: Be explicit about SCM binary locations : [Attachment 392649] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 208641: webkitpy: Be explicit about SCM binary locations
https://bugs.webkit.org/show_bug.cgi?id=208641

Attachment 392649: Patch

https://bugs.webkit.org/attachment.cgi?id=392649&action=review




--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 392649
  --> https://bugs.webkit.org/attachment.cgi?id=392649
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392649&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:79
> +    executable_name = '/usr/bin/svn'

Pretty sure that /usr/bin/svn isn't guaranteed to exist either. Also, this code
isn't about macOS only, or is it?