[webkit-reviews] review denied: [Bug 208025] Web Inspector: VoiceOver doesn't read selected tab : [Attachment 391322] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 208025: Web Inspector: VoiceOver doesn't read selected tab
https://bugs.webkit.org/show_bug.cgi?id=208025

Attachment 391322: Patch

https://bugs.webkit.org/attachment.cgi?id=391322&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 391322
  --> https://bugs.webkit.org/attachment.cgi?id=391322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391322&action=review

>>>> Source/WebInspectorUI/UserInterface/Views/ConsoleTabContentView.js:61
>>>> +		  WI.consoleContentView.prompt.focus();
>>> 
>>> How does VO properly access the Console tab title if focus stays with the
prompt element?
>> 
>> Can you explain why a rAF is needed?  Is it because the element isn't in the
DOM tree, or some other reason?  Rather than rely on the uncertain firing order
of rAFs, how about we set some state on `WI.consoleContentView` (or use a
"cookie" object passed to `showContentView`) that will focus the prompt in the
next `layout()`?  I'm imagining something along the lines of
`WI.SourcesTabContentView.prototype.showScopeChainDetailsSidebarPanel`.
> 
> It doesn't for Console. It just reads "Console prompt".
> 
> I think ideally when switching to the Console tab, it should:
> 1. Immediately focus on the console prompt so if I start typing it should go
to the right place.
> 2. Yet read the Console tab title.
> 
> I don't know how to satisfy both requirements. With this patch it just reads
"Console Prompt" instead of "console tab", "Console Prompt".

I don't think we want to do this.  Automatically focusing the Console prompt
means that as soon as the user selects the Console Tab, they're unable to
immediately change tabs again (e.g. if they mistakenly selected it).  They'd
have to tab all the way back to the tab bar to switch tabs again.