[webkit-reviews] review granted: [Bug 208549] Web Inspector: AXI: can't leave Styles and Computed panels by pressing Tab : [Attachment 392354] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 208549: Web Inspector: AXI: can't leave Styles and Computed panels by
pressing Tab
https://bugs.webkit.org/show_bug.cgi?id=208549

Attachment 392354: Patch

https://bugs.webkit.org/attachment.cgi?id=392354&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 392354
  --> https://bugs.webkit.org/attachment.cgi?id=392354
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392354&action=review

r=me

>
Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:41
9
> +	   if (event.shiftKey && this._panel.focusLastSection) {

Why not mimic `_handleForcedPseudoClassCheckboxKeydown` and have `if (event.key
!== "Tab" || !event.shiftKey)` instead?  That way, `if
(this._panel.focusLastSection)` lines up quite nicely with the
`this._panel.focusLastSection();` on the next line :)