[webkit-reviews] review granted: [Bug 208669] Pre-fetch first page in new PDF loading model : [Attachment 392638] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 208669: Pre-fetch first page in new PDF loading model
https://bugs.webkit.org/show_bug.cgi?id=208669

Attachment 392638: Patch

https://bugs.webkit.org/attachment.cgi?id=392638&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 392638
  --> https://bugs.webkit.org/attachment.cgi?id=392638
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392638&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:98
> +-(void) preloadDataOfPagesInRange:(NSRange)range
onQueue:(dispatch_queue_t)queue completion:(void (^)(NSIndexSet*
loadedPageIndexes))completionBlock;

Space in wrong place.
Same with previous line.

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:711
> +    auto firstPageQueue = WorkQueue::create("PDF first page work queue");

We should reuse this.