[webkit-reviews] review granted: [Bug 208663] [First paint] Fixed sized SVG content should taken into account when computing VNE status : [Attachment 392613] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 5 13:48:34 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 208663: [First paint] Fixed sized SVG content should taken into account
when computing VNE status
https://bugs.webkit.org/show_bug.cgi?id=208663

Attachment 392613: Patch

https://bugs.webkit.org/attachment.cgi?id=392613&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 392613
  --> https://bugs.webkit.org/attachment.cgi?id=392613
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392613&action=review

> Source/WebCore/ChangeLog:9
> +	   Let's add fixed sized SVG to the list if content we track as VNE
pixel count.

if -> of

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:944
> +	   // SVG content tends to have a fixed size construct.

Maybe more words about how we know this is wrong in some ways.


More information about the webkit-reviews mailing list