[webkit-reviews] review denied: [Bug 208607] Use the feature flags mechanism to give default feature preference values : [Attachment 392603] Fix build failures on GTK and WPE

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 208607: Use the feature flags mechanism to give default feature preference
values
https://bugs.webkit.org/show_bug.cgi?id=208607

Attachment 392603: Fix build failures on GTK and WPE

https://bugs.webkit.org/attachment.cgi?id=392603&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 392603
  --> https://bugs.webkit.org/attachment.cgi?id=392603
Fix build failures on GTK and WPE

View in context: https://bugs.webkit.org/attachment.cgi?id=392603&action=review

>> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:40
>> +#endif
> 
> Normally we'd put this into a FooSPI.h header but here the call sites are all
wrapped in USE(APPLE_INTERNAL_SDK) so I'm not sure.

Actually we should put this in an SPI header, and add a prototype for
non-internal builds. You'll need to wrap it all in something that's pull in via
AdditionalFeatureDefines.h like HAVE_OS_FEATURE_ENABLED

>> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:90
>> +#if USE(APPLE_INTERNAL_SDK)
> 
> Weird for USE(NICOSIA) to wrap USE(APPLE_INTERNAL_SDK)

Also you should not wrap this all in USE(APPLE_INTERNAL_SDK) because opensource
builds need to also call the function (otherwise they will have different
behavior).