[webkit-reviews] review granted: [Bug 208541] Running a single layout test makes 28 WebProcessPools (and launches 6 Network processes) : [Attachment 392596] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 208541: Running a single layout test makes 28 WebProcessPools (and launches
6 Network processes)
https://bugs.webkit.org/show_bug.cgi?id=208541

Attachment 392596: Patch

https://bugs.webkit.org/attachment.cgi?id=392596&action=review




--- Comment #11 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 392596
  --> https://bugs.webkit.org/attachment.cgi?id=392596
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392596&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:1162
> +	   m_dummyProcessProxies.remove(process->sessionID());

We are doing a double search here.

> Source/WebKit/UIProcess/WebProcessPool.h:628
> +    HashMap<PAL::SessionID, WebProcessProxy*> m_dummyProcessProxies; //
Lightweight WebProcessProxy objects without backing process.

Could use WeakPtr.