[webkit-reviews] review granted: [Bug 208654] When using the scrolling thread, push ScrollingNodeIDs onto PlatformCALayers : [Attachment 392597] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 208654: When using the scrolling thread, push ScrollingNodeIDs onto
PlatformCALayers
https://bugs.webkit.org/show_bug.cgi?id=208654

Attachment 392597: Patch

https://bugs.webkit.org/attachment.cgi?id=392597&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 392597
  --> https://bugs.webkit.org/attachment.cgi?id=392597
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392597&action=review

Still r+ to keep things moving.

> Source/WebCore/ChangeLog:12
> +	   We only need one ScrollingNodeID per platform layer, since a given
platform layer only
> +	   ever has one scrolling role.

I don't think this is true. Specifically a single layer can meaningfully have
both ViewportConstrained and Positioning roles and the scrolling tree code
deals with this.