[webkit-reviews] review granted: [Bug 208611] Some media tests crash when run in the GPU process : [Attachment 392512] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 208611: Some media tests crash when run in the GPU process
https://bugs.webkit.org/show_bug.cgi?id=208611

Attachment 392512: Patch

https://bugs.webkit.org/attachment.cgi?id=392512&action=review




--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 392512
  --> https://bugs.webkit.org/attachment.cgi?id=392512
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392512&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:2291
> +    bool satisfied = [m_videoOutputDelegate semaphore].waitFor(1_s);

nit: This could also be written as
`m_videoOutputDelegate.get().semaphore.waitFor(1_s);` but I don't know what the
current policy for this kind of thing is.