[webkit-reviews] review granted: [Bug 208583] [GPUP] Implement RemoteAudioSession : [Attachment 392575] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 208583: [GPUP] Implement RemoteAudioSession
https://bugs.webkit.org/show_bug.cgi?id=208583

Attachment 392575: Patch

https://bugs.webkit.org/attachment.cgi?id=392575&action=review




--- Comment #31 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 392575
  --> https://bugs.webkit.org/attachment.cgi?id=392575
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392575&action=review

Much better.

> Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.h:51
> +    using SetActiveCompletion = CompletionHandler<void(bool)>;

I think this is unused.

> Source/WebKit/Shared/WebCoreArgumentCoders.h:1035
> +    WebCore::AudioSession::CategoryType,

We usually try to put these in the same header as the enum class.

> Source/WebKit/WebProcess/GPU/media/RemoteAudioSessionConfiguration.h:39
> +    float sampleRate;

These should probably have default initializers to prevent use of uninitialized
memory if we make a mistake and don't initialize everything somewhere.