[webkit-reviews] review granted: [Bug 208634] [iOS] Make sure a MediStreamTrack clone does not interrupt the being cloned track : [Attachment 392557] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 208634: [iOS] Make sure a MediStreamTrack clone does not interrupt the
being cloned track
https://bugs.webkit.org/show_bug.cgi?id=208634

Attachment 392557: Patch

https://bugs.webkit.org/attachment.cgi?id=392557&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 392557
  --> https://bugs.webkit.org/attachment.cgi?id=392557
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392557&action=review

> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:513
> +    // In case of cloning, we might have more than a single source and we do
not want one to interrupt the other.

What happens if capture is active in the web process?

> LayoutTests/platform/ios/TestExpectations:112
> +fast/mediastream/MediaStreamTrack-clone.html [ Pass ]
> +fast/mediastream/MediaStream-clone.html [ Pass ]
> +fast/mediastream/mediastreamtrack-video-clone.html [ Pass ]

Nice!