[webkit-reviews] review granted: [Bug 208637] Add logging support for capture sources in GPUProcess : [Attachment 392561] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 208637: Add logging support for capture sources in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=208637

Attachment 392561: Patch

https://bugs.webkit.org/attachment.cgi?id=392561&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 392561
  --> https://bugs.webkit.org/attachment.cgi?id=392561
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392561&action=review

> Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp:160
> +    source->setLogger(logger(), source.ptr());

We're not supposed use pointers for log identifiers. You could use
childLogIdentifier(...) like we do for AudioContext and
MediaSourcePrivateAVFObjC.

> Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:209
> +	   source->setLogger(m_connectionProxy->logger(), source.ptr());

Ditto.