[webkit-reviews] review denied: [Bug 208583] [GPUP] Implement RemoteAudioSession : [Attachment 392524] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 208583: [GPUP] Implement RemoteAudioSession
https://bugs.webkit.org/show_bug.cgi?id=208583

Attachment 392524: Patch

https://bugs.webkit.org/attachment.cgi?id=392524&action=review




--- Comment #25 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 392524
  --> https://bugs.webkit.org/attachment.cgi?id=392524
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392524&action=review

> Source/WebKit/GPUProcess/GPUPlatformStrategies.h:42
> +class GPUPlatformStrategies : public WebCore::PlatformStrategies {

Oh please no.  I have worked long and hard to move PlatformStrategies to
PageConfiguration, which is the direction they should be going.  If you can't
get to or from a Page, fail to do whatever you were about to do.  We should
rename PlatformStrategies to LegacyPlatformStrategies.