[webkit-reviews] review granted: [Bug 208625] Make m_viewportConstrainedObjects into a WeakHashSet : [Attachment 392535] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 208625: Make m_viewportConstrainedObjects into a WeakHashSet
https://bugs.webkit.org/show_bug.cgi?id=208625

Attachment 392535: Patch

https://bugs.webkit.org/attachment.cgi?id=392535&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 392535
  --> https://bugs.webkit.org/attachment.cgi?id=392535
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392535&action=review

> Source/WebCore/page/FrameView.h:301
> -    bool hasViewportConstrainedObjects() const { return
m_viewportConstrainedObjects && m_viewportConstrainedObjects->size() > 0; }
> +    bool hasViewportConstrainedObjects() const { return
m_viewportConstrainedObjects && m_viewportConstrainedObjects->computeSize(); }

Use !m_viewportConstrainedObjects->computeEmpty() instead. computeSize() will
iterate over the entire map.