[webkit-reviews] review granted: [Bug 205107] Put all generated JSCells in WebCore into IsoSubspace : [Attachment 392521] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 205107: Put all generated JSCells in WebCore into IsoSubspace
https://bugs.webkit.org/show_bug.cgi?id=205107

Attachment 392521: Patch

https://bugs.webkit.org/attachment.cgi?id=392521&action=review




--- Comment #7 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 392521
  --> https://bugs.webkit.org/attachment.cgi?id=392521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392521&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4679
> +	   push(@implContent, "    else\n");
> +	   push(@implContent, "        spaces.m_subspaceFor${interfaceName} =
makeUnique<IsoSubspace> ISO_SUBSPACE_INIT(vm.heap, vm.cellHeapCellType.get(),
${className});\n");

can we also assert here that the object is not destructible. Maybe even static
assert?