[webkit-reviews] review denied: [Bug 208612] Resource Load Statistics: Keep a count of resource loads per day : [Attachment 392506] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied mmokary at apple.com's request for
review:
Bug 208612: Resource Load Statistics: Keep a count of resource loads per day
https://bugs.webkit.org/show_bug.cgi?id=208612

Attachment 392506: Patch

https://bugs.webkit.org/attachment.cgi?id=392506&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 392506
  --> https://bugs.webkit.org/attachment.cgi?id=392506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392506&action=review

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1307
> +    postTask([this, numberOfDays = WTFMove(numberOfDays), completionHandler
= WTFMove(completionHandler)]() mutable {

No need to WTFMove() an unsigned

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1317
> +	       postTaskReply([resourceLoadCountPerDay =
WTFMove(resourceLoadCountPerDay), completionHandler =
WTFMove(completionHandler)]() mutable {

ditto

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1318
> +		   completionHandler(WTFMove(resourceLoadCountPerDay));

ditto

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:2756
> +    // Transient stats

WebKit comments need to end with a period.

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:2859
> +    // Transient stats

WebKit comments need to end with a period.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:552
> +    completionHandler();

Dont you need to pass a parameter here?

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:887
> +    if (!canSendMessage()) {

Should not be needed.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1526
> +	       process->getResourceLoadCountPerDayForPastDays(m_sessionID,
numberOfDays, WTFMove(completionHandler));

use after move of completionHandler if there is more than one process pool with
a network process.