[webkit-reviews] review granted: [Bug 208606] [VNE layout] Move visually non-empty content reporting to RenderTreeBuilder : [Attachment 392487] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 208606: [VNE layout] Move visually non-empty content reporting to
RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=208606

Attachment 392487: Patch

https://bugs.webkit.org/attachment.cgi?id=392487&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 392487
  --> https://bugs.webkit.org/attachment.cgi?id=392487
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392487&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:925
> +	   if (style.visibility() == Visibility::Visible &&
!style.fontCascade().isLoadingCustomFonts()) {

The isLoadingCustomFonts() seems wrong. It might be loading custom fonts but
rendering with the fallback font, right? There's CSS to control this.

Also I guess we don't care about style.visibility() == Hidden on an ancestor?