[webkit-reviews] review denied: [Bug 208533] [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI : [Attachment 392333] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 208533: [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate
panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
https://bugs.webkit.org/show_bug.cgi?id=208533

Attachment 392333: Patch

https://bugs.webkit.org/attachment.cgi?id=392333&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 392333
  --> https://bugs.webkit.org/attachment.cgi?id=392333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392333&action=review

> Source/WebCore/platform/LocalizedStrings.cpp:1213
> +    return WEB_UI_STRING("Touch ID to sign into this website.", "Use Touch
ID to sign into this website");

What about Face ID?

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.h:53
> +    enum class UserVerification {

: bool