[webkit-reviews] review granted: [Bug 208563] Implement WKTextSelectionRect in terms of WebCore::SelectionRect and WKTextRange in terms of WKTextSelectionRect : [Attachment 392391] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 4 08:50:22 PST 2020


Alex Christensen <achristensen at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 208563: Implement WKTextSelectionRect in terms of WebCore::SelectionRect
and WKTextRange in terms of WKTextSelectionRect
https://bugs.webkit.org/show_bug.cgi?id=208563

Attachment 392391: Patch

https://bugs.webkit.org/attachment.cgi?id=392391&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 392391
  --> https://bugs.webkit.org/attachment.cgi?id=392391
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392391&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4465
> +    auto rects = adoptNS([[NSMutableArray alloc]
initWithCapacity:coreRects.size()]);

arrayWithCapacity?


More information about the webkit-reviews mailing list