[webkit-reviews] review granted: [Bug 208558] [LFC][IFC] Display::Run::TextContent::expand(unsigned) is called with the value of -1. : [Attachment 392408] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 208558: [LFC][IFC] Display::Run::TextContent::expand(unsigned) is called
with the value of -1.
https://bugs.webkit.org/show_bug.cgi?id=208558

Attachment 392408: Patch

https://bugs.webkit.org/attachment.cgi?id=392408&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 392408
  --> https://bugs.webkit.org/attachment.cgi?id=392408
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392408&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:-836
> -    m_textContent->expand(-1);

wut

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:837
> +    constexpr size_t trailingTrimmableContentLength = 1;
> +    m_textContent->shrink(trailingTrimmableContentLength);

I have concerns.