[webkit-reviews] review granted: [Bug 208554] Add SPI _WKResourceLoadInfo.loadedFromCache : [Attachment 392363] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 208554: Add SPI _WKResourceLoadInfo.loadedFromCache
https://bugs.webkit.org/show_bug.cgi?id=208554

Attachment 392363: Patch

https://bugs.webkit.org/attachment.cgi?id=392363&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 392363
  --> https://bugs.webkit.org/attachment.cgi?id=392363
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392363&action=review

> Source/WebKit/ChangeLog:6
> +	   Reviewed by NOBODY (OOPS!).

Nit - it’s admittedly pretty self-explanatory, but it would be nice to have a
sentence or two explaining what this new SPI does.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:328
> +    EXPECT_EQ(archiveData.length, 589ull);

Ideally we'd have a test that checks the value of -loadedFromCache, but maybe
it can be done as a followup.