[webkit-reviews] review granted: [Bug 207920] Crash in SVGElement::removeEventListener with symbol element : [Attachment 392356] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Doug Kelly <dougk at apple.com>'s
request for review:
Bug 207920: Crash in SVGElement::removeEventListener with symbol element
https://bugs.webkit.org/show_bug.cgi?id=207920

Attachment 392356: Patch

https://bugs.webkit.org/attachment.cgi?id=392356&action=review




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 392356
  --> https://bugs.webkit.org/attachment.cgi?id=392356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392356&action=review

> LayoutTests/fast/events/detached-svg-parent-window-events-expected.txt:9
> +TEST COMPLETE

Ugh... we need to define jsTestIsAsync = true.

> LayoutTests/fast/events/detached-svg-parent-window-events.html:11
> +	       didFireOnError = false;

Do this here: jsTestIsAsync = true

> LayoutTests/fast/events/detached-svg-parent-window-events.html:22
> +			   if (window.testRunner)
> +			       testRunner.notifyDone();

And call finishJSTest instead of this if (~) testRunner.notifyDone().