[webkit-reviews] review granted: [Bug 208546] Make WebsiteDataStore::processPools() parameter mandatory to make it clear it may create a process pool : [Attachment 392348] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 208546: Make WebsiteDataStore::processPools() parameter mandatory to make
it clear it may create a process pool
https://bugs.webkit.org/show_bug.cgi?id=208546

Attachment 392348: Patch

https://bugs.webkit.org/attachment.cgi?id=392348&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 392348
  --> https://bugs.webkit.org/attachment.cgi?id=392348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392348&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:304
> +    enum class EnsureHasProcessPool : bool { No, Yes };
> +    HashSet<RefPtr<WebProcessPool>> processPools(EnsureHasProcessPool,
size_t limit = std::numeric_limits<size_t>::max()) const;

The idiom we often use for things like this is to have two functions:
1) ensureProcessPools()
2) existingProcessPools() or possibly just processPools().