[webkit-reviews] review granted: [Bug 208536] [Internals] Introduce Internals::updateLayoutAndStyleRecursively : [Attachment 392329] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 208536: [Internals] Introduce Internals::updateLayoutAndStyleRecursively
https://bugs.webkit.org/show_bug.cgi?id=208536

Attachment 392329: Patch

https://bugs.webkit.org/attachment.cgi?id=392329&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 392329
  --> https://bugs.webkit.org/attachment.cgi?id=392329
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392329&action=review

> Source/WebCore/ChangeLog:10
> +	   However in certain cases (see Hyatt's optimization on lazy
offsetHeight/Width computation) this call can leave the tree partially dirty.

Maybe reference an actual function rather than assuming that we all know what
hyatt's optimizations are.

> Source/WebCore/testing/Internals.idl:533
> +    void updateLayoutAndStyleRecursively();

I think "for all frames" would be clearer that "recursively"; it's not clear
what's being recursed on.

> LayoutTests/fast/images/animated-gif-no-layout.html:13
> +	       internals.updateLayoutAndStyleRecursively();

Why not replace or remove the document.body.offsetWidth above?