[webkit-reviews] review granted: [Bug 208038] [CG] Change the UTI of the "WebP" image to be "com.google.webp" : [Attachment 392307] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 3 14:10:02 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 208038: [CG] Change the UTI of the "WebP" image to be "com.google.webp"
https://bugs.webkit.org/show_bug.cgi?id=208038

Attachment 392307: Patch

https://bugs.webkit.org/attachment.cgi?id=392307&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 392307
  --> https://bugs.webkit.org/attachment.cgi?id=392307
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392307&action=review

> Source/WebCore/platform/graphics/cg/UTIRegistry.cpp:67
> +	       if (CFArrayContainsValue(systemImageTypes.get(), CFRangeMake(0,
count), string.get()))

This is linear search. How big is systemImageTypes?


More information about the webkit-reviews mailing list