[webkit-reviews] review granted: [Bug 208492] Path::m_path should be a RetainPtr<CGMutablePathRef> on platforms that use CoreGraphics : [Attachment 392315] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 208492: Path::m_path should be a RetainPtr<CGMutablePathRef> on platforms
that use CoreGraphics
https://bugs.webkit.org/show_bug.cgi?id=208492

Attachment 392315: Patch

https://bugs.webkit.org/attachment.cgi?id=392315&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 392315
  --> https://bugs.webkit.org/attachment.cgi?id=392315
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392315&action=review

> Source/WebCore/platform/graphics/cg/PathCG.cpp:220
>      CGMutablePathRef path = CGPathCreateMutable();

This would be better as RetainPtr<CGMutablePathRef> path = adoptCF(), and do a
WTFMove below.

> Source/WebCore/platform/graphics/cg/PathCG.cpp:223
> +    CGMutablePathRef path =
CGPathCreateMutableCopyByTransformingPath(m_path.get(), &transformCG);

Ditto.