[webkit-reviews] review granted: [Bug 208486] [WebGL2] Implement texImage2D(TexImageSource) for RGBA/RGBA/UNSIGNED_BYTE ImageElements : [Attachment 392219] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 208486: [WebGL2] Implement texImage2D(TexImageSource) for
RGBA/RGBA/UNSIGNED_BYTE ImageElements
https://bugs.webkit.org/show_bug.cgi?id=208486

Attachment 392219: Patch

https://bugs.webkit.org/attachment.cgi?id=392219&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 392219
  --> https://bugs.webkit.org/attachment.cgi?id=392219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392219&action=review

> Source/WebCore/ChangeLog:8
> +	   WIP implementation of WebGL 2 texImage2D(TexImageSource).

Maybe say "Partial"?

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3796
> +	   // Normal pure SW path.

// Fallback software path.