[webkit-reviews] review granted: [Bug 208503] Web Inspector: setting the frontend appearance doesn't update the window when undocked : [Attachment 392253] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 208503: Web Inspector: setting the frontend appearance doesn't update the
window when undocked
https://bugs.webkit.org/show_bug.cgi?id=208503

Attachment 392253: Patch

https://bugs.webkit.org/attachment.cgi?id=392253&action=review




--- Comment #2 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 392253
  --> https://bugs.webkit.org/attachment.cgi?id=392253
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392253&action=review

> Source/WebCore/inspector/InspectorFrontendHost.cpp:239
> +	       m_frontendPage->setUseDarkAppearanceOverride(false);

You should not need to do this if you force the appearance on the window.

> Source/WebCore/inspector/InspectorFrontendHost.cpp:247
> +	       m_frontendPage->setUseDarkAppearanceOverride(true);

Ditto.

> Source/WebCore/inspector/InspectorFrontendHost.cpp:254
>	   m_frontendPage->setUseDarkAppearanceOverride(WTF::nullopt);

Ditto.